[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Lock comment editing UI {was: Re: "svn lock" crashes if editor exits without saving a lock message]

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-04-11 09:12:34 CEST

On Sun, 10 Apr 2005, Julian Foad wrote:

..
> There were occasions when leaving a lock message would have been
> useful, maybe
> once in every few months, but on a daily basis I would lock ("check out")
> several files without having anything useful to say about the fact except the
> obvious "I'm working on these." The locks only got in the way occasionally,
> when a developer had forgotten about them or the work was taking longer than
> expected, and then the question I really needed to ask was not "Why did you
> take out this lock?" but "Have you finished with this, forgotten about it, or
> what?" which could not have been answered in advance in a lock comment.
>
This was a nice explanaition, Julian, and having worked like this myself,
I agree. What I implemented in the cmdline client was what I thought was
concensus (since it is in the UI spec).

It now seems like many people want the editor not to be invoked, at least
not by default. This seems reasonable to me. It is easier to add it later
than back it out when 1.2 is released. I see little point in a cmdline
switch to run the editor (as ghudson proposed), since the user can as
easily run the editor herself. A config option would make sense.

Since we don't seem to agree about the message template, I think it is
best to just drop this editor stuff altogether for 1.2 and reintroduce it
in 1.3 if people want it. Ofcourse, -m and -F would be available.

Comments?

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 11 09:07:40 2005

This is an archived mail posted to the Subversion Dev mailing list.