[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Lock comment editing UI {was: Re: "svn lock" crashes if editor exits without saving a lock message]

From: John Szakmeister <john_at_szakmeister.net>
Date: 2005-04-10 18:44:04 CEST

On Sunday 10 April 2005 11:55, Greg Hudson wrote:
> On Sat, 2005-04-09 at 06:25, John Szakmeister wrote:
> > I'm all for consistency. To me, locking is almost the same as
> > committing, in that it involves interaction with the server that is
> > longer term. So, I'd like to see it have the same format as the log
> > message.
> Well, I have a rather different view. I'm shocked and dismayed to find
> out that "svn lock filename" brings up an editor by default. I think
> most users will view lock comments as an annoyance and will prefer not
> to use them. "svn lock filename" should just lock the file with no
> comment, and we should have an explicit flag to bring up an editor to
> record the comment with. Once we switch to that model, it doesn't
> matter as much what comes up in the editor window.

Now that I've found out that locks aren't all acquired atomically, I'm
inclined to agree. As long as there is a way to set a comment and
enforce it (via a hook script or something), then I think most the people
that I know using Subversion in the work place will be happy.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 10 20:04:16 2005

This is an archived mail posted to the Subversion Dev mailing list.