[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Lock comment editing UI {was: Re: "svn lock" crashes if editor exits without saving a lock message]

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-04-10 21:06:40 CEST

Greg Hudson wrote:
> On Sat, 2005-04-09 at 06:25, John Szakmeister wrote:
>>I'm all for consistency. To me, locking is almost the same as committing,
>>in that it involves interaction with the server that is longer term. So,

That's an impractical view of the situation. Both persist for a while, but
commits persist essentially for ever, whereas locks are inherently transient,
"longer term" than something maybe, but definitely "short term" compared to
commits. Lock comments are far more likely to be unwanted.

>>I'd like to see it have the same format as the log message.

It seems reasonable for the lock message template to have the same format as
the commit message template.

> Well, I have a rather different view. I'm shocked and dismayed to find
> out that "svn lock filename" brings up an editor by default. I think
> most users will view lock comments as an annoyance and will prefer not
> to use them. "svn lock filename" should just lock the file with no
> comment, and we should have an explicit flag to bring up an editor to
> record the comment with. Once we switch to that model, it doesn't
> matter as much what comes up in the editor window.

I agree. The old trick of configuring the log message editor to be some null
command is not feasible because one doesn't normally want to disable commit
messages as well.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 10 21:10:10 2005

This is an archived mail posted to the Subversion Dev mailing list.