[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: dav_new_error_tag and the Apache error log

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2005-04-08 21:28:48 CEST

On Apr 8, 2005, at 2:01 PM, C. Michael Pilato wrote:

> Philip Martin <philip@codematters.co.uk> writes:
>
>> I don't think we should be putting misleading information into the
>> error log, so we need to do one of:
>>
>> - explicitly set errno to zero before every call to dav_new_error_tag
>> - use a dav_svn_new_error_tag wrapper that sets errno to zero
>> - change mod_dav to ignore errno
>>
>> What do people think?
>
> I think I love you for figuring out why those busted log lines show
> up.
>
> And I think I'd like a util.c/dav_svn__new_error_tag() (note the
> double underscore, which is what I'm sure you meant, unless of course
> you happen to know that this is an API that needs exposure outside of
> mod_dav_svn itself, in which case your suggestion is the better one,
> and I can stop typing all this stuff parenthetically about this)
> function.
>

+1

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 8 21:31:07 2005

This is an archived mail posted to the Subversion Dev mailing list.