[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: dav_new_error_tag and the Apache error log

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2005-04-12 08:13:35 CEST

--On Friday, April 8, 2005 5:53 PM +0100 Philip Martin
<philip@codematters.co.uk> wrote:

> - explicitly set errno to zero before every call to dav_new_error_tag
> - use a dav_svn_new_error_tag wrapper that sets errno to zero
> - change mod_dav to ignore errno
>
> What do people think?

FWIW, you can just set err->save_errno to 0. So, a local dav_new_error_tag
can just do that instead of setting errno.

That said, I like answer #3 the best. =)

Looking at this, I'm not sure that mod_dav needs to capture this information
anymore. httpd as a whole in 2.0.x doesn't report errno implicitly - yet
1.3.x does. I think this is just an artifact of mod_dav not being updated
when httpd stopped reporting errno (in 2.0a1!). httpd 2.x just uses the
status value passed which is likely to be far more reliable than errno given
the use of APR.

But, I wouldn't be against implementing a workaround for 2.0.x - just expect
that it'll be fixed by httpd 2.2. =)

Hope this makes sense. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 12 08:14:34 2005

This is an archived mail posted to the Subversion Dev mailing list.