[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Stop 'svn import' from importing empty paths

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-04-08 17:59:55 CEST

"S.Ramaswamy" <ramaswamy@collab.net> writes:

> > This patch breaks the following functionality:
> >
> > svn import -m "" empty-dir URL-OF-REPOS/new-dir
> >
> > As I mentioned in IRC yesterday, doing this right does not involve
> > checking for empty directories -- it involves the import driver
> > remembering (perhaps as a boolean in some context structure) if it ever
> > actually did anything in the repository (probably as simple as
> > remembering if "add_file" or "add_directory" was called), and if not,
> > then call abort_edit() instead of close_edit().
> >
>
> Mike, Thanks. Revised patch attached.
>
> ChangeLog:
>
> * subversion/include/svn_client.h
> (svn_client_ctx_t) : Added a new boolean to this struct - 'repos_changed',
> to make libsvn_client remember if any changes were made to the
> repository.

Oh. Dude, when I said "some context structure", I meant one that was
private to the import operation. The svn_client_ctx_t is a very
inappropriate place for this new boolean.

The rest of the change looks okay -- we just can't use that structure
to house our boolean.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 8 18:04:58 2005

This is an archived mail posted to the Subversion Dev mailing list.