[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] new parameter option '--full-paths' for 'svnlook tree'

From: <Mathias.Weinert_at_gfa-net.de>
Date: 2005-04-07 11:34:02 CEST

Philip Martin writes:
> Mathias.Weinert@gfa-net.de writes:
>
> > I now made a new patch against revision 13968 and attached it to this
> > mail.
>
> Please include a log message when you submit patches.
>

Sorry for this. I included one in my first mail in this thread but as it
was only
about main.c I should have written a new one.
In future I will always include the log message when I submit a patch.

> > I hope that it is in the right format and that you can read and use
it.
>
> A mime-type of text/plain is better than application/octet.

The mail client I used didn't allow me to chose the mime-type and so
I hoped that it will automatically use text/plain for such a file. I'll
try
to use another mail client next time.

>
> > I also tried to do some python programming. I have no idea if it is
o.k.
> > and
> > if it is what you expected. I added two 'svnlook tree' calls in the
first
> > test
> > in svnlook_tests.py. They both check if 'svnlook tree --full-paths'
fits
> > the
> > normal 'svnlook tree' results but don't test the output of 'svnlook
tree'
> > itself.
>
> Looks OK, but I had to change lstrip(' ') to lstrip() and rstrip('\n')
> to rstrip() to avoid errors like:
>
> TypeError: strip() takes exactly 0 arguments (1 given)
>
> I'm using python 2.1.3, perhaps you have something different?

I'm using python 2.4 (and there it works).

>
> Thanks for the patch, I committed it in r13976.
>
> --
> Philip Martin

Thank you for commiting the patch!

Mathias
Received on Thu Apr 7 12:03:02 2005

This is an archived mail posted to the Subversion Dev mailing list.