[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Eliminate three poor type casts.

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-04-06 21:07:55 CEST

Julian Foad <julianfoad@btopenworld.com> writes:

> Index: subversion/mod_dav_svn/deadprops.c
> ===================================================================
> --- subversion/mod_dav_svn/deadprops.c (revision 13967)
> +++ subversion/mod_dav_svn/deadprops.c (working copy)
> @@ -286,8 +286,7 @@ static dav_error *dav_svn_db_output_valu
> across the wire. */
> if (! svn_xml_is_xml_safe(propval->data, propval->len))
> {
> - propval = (svn_string_t *)svn_base64_encode_string(propval, pool);
> - xml_safe = propval->data;
> + xml_safe = svn_base64_encode_string(propval, pool)->data;

Personal preference: I *really* dislike FUNCTION->MEMBER syntax in C
code.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 6 23:02:03 2005

This is an archived mail posted to the Subversion Dev mailing list.