[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index


From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-04-06 13:20:24 CEST

Ben Collins-Sussman wrote:
> On Apr 4, 2005, at 2:36 PM, Julian Foad wrote:
>> Aha! I have just seen that "SVN_ERR_FS_PATH_LOCKED" is tested by the
>> macro "SVN_ERR_IS_LOCK_ERROR", and therefore perhaps is intended only
>> to mean, "You can't lock this path because it is already locked". If
>> that's the case, may we rename it to "SVN_ERR_FS_PATH_ALREADY_LOCKED"?
>> Or at least document it as such.
> Yes, I think that's exactly the difference between the two error codes.

Thanks for clarifying it to me. I'll stop pushing for a clarification in the
source code if no-one else is bothered by it.

What about the correctness of subversion/libsvn_ra_dav/commit.c:

> /* A locking-related error most likely means we were deleting a
> directory rather than a file, and didn't send all of the
> necessary lock-tokens within the directory. */
> if (serr && ((serr->apr_err == SVN_ERR_FS_BAD_LOCK_TOKEN)
> || (serr->apr_err == SVN_ERR_FS_NO_LOCK_TOKEN)
> || (serr->apr_err == SVN_ERR_FS_LOCK_OWNER_MISMATCH)
> || (serr->apr_err == SVN_ERR_FS_PATH_LOCKED)))
> {
> /* Re-attempt the DELETE request as if the path were a directory.


- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 6 20:57:17 2005

This is an archived mail posted to the Subversion Dev mailing list.