[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Very emphatic -1 for r13369 (svn:keywords canonicalization)

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2005-04-06 13:01:15 CEST

On Tue, 2005-04-05 at 21:35, Max Bowsher wrote:
> r13369 canonicalizes svn:keywords values.
>
> The canonicalization algorithm is flawed, and silently deletes anything that
> it does not understand.
>
> This means that when we add additional keywords in the future, old clients
> will be unable to edit a svn:keywords property containing a new value
> without inadvertently removing all the keywords which the old client version
> does not support.
>
I thought this would be a good fallout of the canonicalization ( removal
of junk input ). However, I agree with your point.
[...]
> Once we have cleared up these issues, we can reintroduce a properly designed
> canonicalization system in 1.3.
>
I have sent a patch ( the whole patch ) with modified test cases. Pl.
let me know if this satisfies the above point. Thanks for the review.
>
> Max.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 6 20:54:59 2005

This is an archived mail posted to the Subversion Dev mailing list.