Very emphatic -1 for r13369 (svn:keywords canonicalization)

r13369 canonicalizes svn:keywords values.

The canonicalization algorithm is flawed, and silently deletes anything that
it does not understand.

This means that when we add additional keywords in the future, old clients
will be unable to edit a svn:keywords property containing a new value
without inadvertently removing all the keywords which the old client version
does not support.

Also, we have an issue regarding custom keywords. I'm not sure if this has
been considered yet, but if it is to extend the svn:keywords syntax in any
way, it is vital that we do not release a version with a destructive
canonicalization routine.

On this basis, I am about to revert the revision in question, and call a
vote in the 1.2.x STATUS file for reverting it there too.

Once we have cleared up these issues, we can reintroduce a properly designed
canonicalization system in 1.3.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 5 18:05:46 2005