[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: attn: lundblad; FSFS gcc dependency

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-04-05 21:07:10 CEST

On Tue, 5 Apr 2005, Greg Hudson wrote:

> r13906 added the following line of code:
>
> + struct commit_baton cb = { new_rev_p, fs, txn };
>
> Initializing an aggregate object with non-constant data is a gcc-ism
> (also supported by C99, perhaps, but not C89).
>
Fixing. Thanks.

> On a more subjective note, thunk abstractions in C are really
> cumbersome. I think it would clearer and more concise to duplicate
> the svn_fs_fs__with_write_lock logic in the three places it's needed,
> like so:
>
Well, I disaggree. We use this idiom in BDB for trails. I think it is
readable.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 6 18:29:36 2005

This is an archived mail posted to the Subversion Dev mailing list.