On Sun, 3 Apr 2005, D.J. Heap wrote:
> Peter N. Lundblad wrote:
> [snip]
> > Well, the pool is cleared, eventually. We don't clear subpools on error.
> > I'm going to change this particular case (holding the write lock in FSFS),
> > since we don't know when the caller will clear the pool and locks should
> > be released when they're not needed anymore.
> >
> Sounds good to me. There are 3 or so other places where
> svn_fs_fs__get_write_lock is called and probably needs the same
> treatment on errors, I would think. I can post a patch for those later,
> if you don't get them.
>
I am replacing get_write_lock with a new with_write_lock function taking
another function/baton pair. That's happening in all places, including
commit.
I timed out yesterday, but I'll finish it tonight. Hopefully before we
merge for 1.2, if that's actually happening today.
Thanks,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 4 09:09:06 2005