[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Win32 Tests -- locks-test

From: D.J. Heap <dj_at_shadyvale.net>
Date: 2005-04-04 04:02:08 CEST

Peter N. Lundblad wrote:
[snip]
> Well, the pool is cleared, eventually. We don't clear subpools on error.
> I'm going to change this particular case (holding the write lock in FSFS),
> since we don't know when the caller will clear the pool and locks should
> be released when they're not needed anymore.
>
> Regards,
> //Peter
>

Sounds good to me. There are 3 or so other places where
svn_fs_fs__get_write_lock is called and probably needs the same
treatment on errors, I would think. I can post a patch for those later,
if you don't get them.

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 4 04:03:32 2005

This is an archived mail posted to the Subversion Dev mailing list.