[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r13838 - branches/1.1.x

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2005-04-02 00:55:52 CEST

--On Friday, April 1, 2005 1:30 PM -0800 Ben Reser <ben@reser.org> wrote:

> The option names -apri and -apru were discussed at length when I added
> them. Karl felt that -api was ambiguous and shouldn't be used. Please
> change this back.

apr, apu, and api are the official acronyms used by APR (i.e. apu-config).
Therefore, for consistency, I believe we need to follow their acronyms not
come up with our own acronyms.

> I really think we should leave the cleanup code here just for paranoia
> purposes. Your change completely wipes it out.

No, it doesn't. It just moved inside the 'install_dependency' function.

As we discussed in #svn, we should switch it to 'distclean' instead of
'extraclean' so that it works with neon. The extra steps included in
'extraclean' are not really required for APR-* because we're re-running
buildconf which overwrites configure, aclocal.m4, and
apr_private_config.h.in, etc. anyway.

So, switching to 'distclean' should be sufficient for our purposes. Agreed?

(This only matters for folks who use 'dirty' tarball extracts rather than
'clean' tarball extracts.)

> I reiterate the veto I made to introducing code to use svn export to
> fetch dependencies in the past. The dependencies must be verified as
> valid releases. I don't see anyway to do that with export. Tarballs
> have PGP/GPG signatures that can be validated. I leave it up to the
> individual projects to be sure that however they got their code they put
> in their tarball is valid. If they want to trust their repo that's up
> to them. But I really think we should only be using released tarballs
> for dependencies.

I'm concerned that this adds an extra step that may not always be needed.
I'd be fine with saying that official releases must use extracted tarballs,
but I think that there are legitimate times (i.e. for non-official
releases) where fetching the dependencies via svn export is fine.
Therefore, to make it easier to produce those types of releases, I think
the export calls should stay. Note that using 'svn export' isn't the
default - using the local files is. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Apr 2 00:57:19 2005

This is an archived mail posted to the Subversion Dev mailing list.