[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch: add svn_client_get_repos_path

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-04-01 22:28:35 CEST

On Fri, 1 Apr 2005, Max Bowsher wrote:

> Peter N. Lundblad wrote:
> > On Thu, 31 Mar 2005, Barry Scott wrote:
> >
> >> On Mar 31, 2005, at 12:40, Peter N. Lundblad wrote:
> >>
> >>> instead of new special-case functions, maybe we should export some
> >>> general
> >>> purpose client function to open an RA session, such as
> >>> svn_client__ra_session_from_path?
> >>
> >> I used this function to test out the code fragment I posted. Making
> >> this function
> >> a supported interface would make me happy.
> >>
> >> Peter would you be willing to turn svn_client__ra_session_from_path
> >> into a
> >> supported svn_client_ra_session_from_path?
> >>
> > I'll apply a patch from you, if no one else objects. Just rename the
> > function (removing one _), fix the docstring to be doxygen, update the
> > call sites and all should be fine. I'll do it for 1.2 if it gets ready
> > before the branch is created.
>
> No, please don't, at least not without more careful examination. The API
> should be more designed that that.
>
> For example - right now, we have svn_client__open_ra_session() and
> svn_client__ra_session_from_path(). Both create a ra session. We should
> consider whether we ought to be exposing both, or (more likely) a carefully
> designed merge of the two.
>
Well, I think svn_client_ra_session_from_path would be appropriate. It is
quite simple when you just want an RA session to ask the repository
something about a path.

But when I look at the new APIs in 1.2, I realize that Barry may already
have what he wants, namely svn_client_info. Would that fill your needs,
Barry?

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 1 22:24:52 2005

This is an archived mail posted to the Subversion Dev mailing list.