Re: svn commit: r13754 - trunk/contrib/client-side

Simon Perreault <nomis80@nomis80.org> writes:

> On March 29, 2005 18:48, Philip Martin wrote:
>> Please follow the project log message guidelines in the HACKING file,
>> something like:
>>
>> * contrib/client-side/svn-clean (blah): blah blah blah
>
> Sorry, I thought I was following the instructions in the HACKING file:
>
> * If your change was only to one file, or was the same change to
> multiple files, then there's no need to list their paths in the
> log message (because "svn log" can show the changed paths for
> that revision anyway). Only when you need to describe how the
> change affected different areas in different ways is it
> necessary to organize the log message by paths and symbols, as
> in the examples above.

Hmm, if I run 'svn log' on my working copy I get your log message, and
even though it applies to only one file I don't know which file that
it. The rule you quote only makes sense if I'm running 'svn log' on
the file in question, but that's not the common case.

>> Use 'svn pset/pedit --revprop -r' to change the log message for this
>> revision and r13050.
>
> I'll wait for you to get back to me before I do so. If I must change my log
> message, I will modify the HACKING file accordingly.

Please change the log message, it's very annoying to have log messages
that don't fit the pattern used by everyone else.

>> You are not mentioned in the COMMITTERS file, please add your details
>> to the bottom of the Miscellaneous section.
>
> Done. I've followed what's written in the HACKING file in my log message. If
> you tell me that it's wrong then I'll change that one too.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org