Re: Feature proposal: maintain timestamps on svn hotcopy

Scott Parkerson <scott.parkerson@gmail.com> writes:

> I've been going over the code in libsvn_subr/io.c and am
> considering modifying svn_io_copy_file to take an extra boolean
> flag (copy_times). By default, this behavior would be turned off
> on all callers of that function EXCEPT for the codepath that gets
> triggered when the user runs "svnadmin hotcopy --preserve-times",
> or somesuch. This would keep the code change impact down,
> as well.
>
> My questions are: a) when doing this patch, what do I need to
> look out for?

You can't add a parameter to svn_io_copy_file as that would break the
ABI. You need to rename the function, to svn_io_copy_file2 say, add
the new parameter and implementation, and then write a wrapper with
the original name and parameter list that calls the new function.

> and b) is there a reason this isn't done now (i.e.
> does it screw with assumptions made during design)?
> Furthermore, is there an existing unit test for this function, or is
> to me to come up with one?

I don't think there is a specific test for svn_io_copy_file but the
regression tests as whole exercise it. The hotcopy command gets run
by subversion/tests/clients/cmdline/svnadmin_tests.py, you might like
to add to that.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org