Max Bowsher wrote:
> OK, here are the results of my recent work on keywords as hash.
>
> Firstly, I've split the whole thing into 4 individually committable
> sections:
Before I review the patch itself, I want to point out that in all earlier
iterations of this patch, I also broke it down to multiple patches (two in my
case, constituting your 1 and 2-4). No one stepped forward to attempt a review
until I combined both parts, at which point both Julian and Phillip gave me some
feedback. I realize that this may have simply been due to who was available for
a review and when.
I do not intend to criticize anyone here, since I value the superior coding that
goes into this project. But I want to suggest that the more senior developers
should consciously try to respond to patches with at least some feedback, even
if you cannot perform a full review. It would have been valuable to me to have
confirmation that others thought performing the core changes in libsvn_subr
independent of the other libraries usage of that code was appropriate here. I
got no feedback, and hence stopped sending two patches, thus making your review
more difficult.
>
> 1. include & libsvn_subr
> 2. libsvn_wc
> 3. libsvn_client
> 4. cmdline client & tests
>
> At the moment, I am *only* working on section 1.
>
> I've incorporated Justin's changes, and also made *MANY* of my own. (So
> please could John and Justin re-review this)
>
You mean Julian. I'll re-review after breakfast...
John
--
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 22 13:22:57 2005