Re: [PATCH] Issue #2100: --revision ARG1:ARG2 handling improvement

Ryan Kersh wrote:
> Log message included below and patch attached.

Thanks for volunteering this work, but ...

I don't recall any discussion of this issue on the mailing list; was there? My
first thoughts are along the lines of: isn't this horribly inconsistent for
some commands where the default is not 0:HEAD, e.g. "svn log" which defaults to
BASE:1 ?

Maybe I'm wrong. I can certainly see that it would be handy in some
situations. List the uses of it in different Subversion commands, comparing to
the present defaults, and convince me that there are no ugly contradictions or
surprises, only goodness.

> This patch didn't break any of the make check tests.

Good. It wouldn't be acceptable if it did.

> Should I add a
> test to subversion/tests/libsvn_subr/opt-test.c to put
> svn_opt_parse_revision through the paces as well?

That would be very nice, though not essential.

> [[[
> Implement Issue #2100: --revision ARG1:ARG2 handling improvement.

The description of this issue and this email thread and this patch could be
more specific. Maybe "Make revision range ends optional"?

A documentation patch to go with this would be really nice.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 21 17:11:39 2005