[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r13500 - in branches/locking/subversion: include libsvn_fs_base libsvn_fs_fs

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2005-03-19 13:17:08 CET

On Mar 19, 2005, at 3:23 AM, cmpilato@tigris.org wrote:
> * subversion/include/svn_fs.h
> (svn_fs_lock): Update docstring to warn callers that the lock they
> send in might not be the exact lock data used (because of the path
> canonicalization stuffs).

Why is this necessary to document? Doesn't libsvn_fs auto-canonicalize
*every* incoming path already?

Ah... perhaps it's because this is the only API in which the caller
passes in a structure as input, one that might be reused. Hm.

I wonder if svn_fs_attach_lock() should canonicalize the path within
the incoming structure...? Wouldn't that be more elegant than making
the caller re-fetch the svn_lock_t?

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 19 13:18:24 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.