[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] hot-backup.py.in

From: Chris Wesseling <chris.wesseling_at_xs4all.nl>
Date: 2005-03-17 20:51:26 CET

On Thu, Mar 17, 2005 at 07:34:44PM -0000, Max Bowsher wrote:
> Chris Wesseling wrote:
> >On Thu, Mar 17, 2005 at 03:01:39AM -0000, Max Bowsher wrote:
> >>chars@xs4all.nl wrote:
> >[hot-backup.py breaks on ancient Python 1.5.2 (RH 7.2)
> >tried the following]
> >>>try:
> >>>dir(os.popen3)
> >>>except AttributeError:
> >>>import popen2
> >>>
> >>>def popen3fix(cmd):
> >>> outfile, infile, errfile = popen2.popen3(cmd)
> >>> return infile, outfile, errfile
> >>>
> >>>os.popen3 = popen3fix
> >[still breaks on a function new in Python 1.6, changed shebang to
> >python2]
[python2 is not standard, python is]
> >>Max.
[we should change then]
> I've already done this in trunk.
> >And at least document the needed Python version in the code, if not
> >implement some version checking or --help.
> >Now you just get an Error and a Traceback, not particularly friendly to
> >non hackers.
> >I'm new to python (these were my first lines of code), so my fingers
> >are itching to dive into some good code.
> >If we manage to get some concensus here, I'm more than willing to put in
> >my effort. Be it just changing the shebangs and drop a line in a README.
> Shebangs done.
> I'm not sure where the best location for a such a note would be. We could
> mention expand the description of python requirements in INSTALL, I guess,
> though I'm not sure how many people would look there.
> Max.

Perhaps in a comment in the first couple of lines of the script.
Most scripts allready describe their use there anyway, or have their
default values or even configuration setttings there.

A little note in the INSTALL that mentions this, and we would cover two of the
most looked for places.

Or maybe a README/INSTALL in the tools dir. If you're going to use the
scripts, you'll have to pass there.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 17 20:52:43 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.