[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r13458 - branches/locking/subversion/mod_dav_svn

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-03-17 18:57:57 CET

Garrett Rooney <rooneg@electricjellyfish.net> writes:

> cmpilato@tigris.org wrote:
> > Author: cmpilato
> > Date: Thu Mar 17 11:39:31 2005
> > New Revision: 13458
> > Modified:
> > branches/locking/subversion/mod_dav_svn/dav_svn.h
> > branches/locking/subversion/mod_dav_svn/repos.c
> > Log:
> > Locking branch: check the User-Agent header to determine if our
> > accessor claims to be a Subversion client.
> > * subversion/mod_dav_svn/dav_svn.h
> > (dav_svn_repos): Add 'is_svn_client' member.
> > * subversion/mod_dav_svn/repos.c
> > (dav_svn_get_resource): Populate new repos->is_svn_client member.
> >
> Refresh my memory. Why are we going down this road? The idea of
> special casing based on the User-Agent just seems oh so wrong to
> me...

I thought this, too. But we already have tons of special-casing based
on custom headers supplied by Subversion clients, all aimed at making
the Subversion client experience better without hurting the generic
DAV clients. So, I started down the road of adding another custom
Subversion client header when it occurred to me that:

   - doing so would not help my server deal with older Subversion
     clients, and

   - I'm only using this where it really wouldn't be the end of the
     world if a non-Subversion client just happened to look like one
     by its User-Agent droppings.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 17 19:02:06 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.