Madan U Sreenivasan wrote:
> +#----------------------------------------------------------------------
> +# Test for copy into a non-existent url path
> +def url_2_non_existent_url_path(sbox):
A minor nit: I'd prefer "url_to_non_existent_url_path" over
"url_2_non_existent_url_path".
> + "svn cp src-URL non-existent-URL-path"
> +
> + sbox.build()
> + wc_dir = sbox.wc_dir
> +
> + dirURL1 = svntest.main.current_repo_url + "/A/B/E"
> + dirURL2 = svntest.main.current_repo_url + "/G/C/E/I"
> + errstr = [ "svn: Path 'G' not present\n" ]
> +
> + # Expect failure on 'svn cp SRC DST'
> + # where one or more ancestor directories of
> + # DST do not exist
> + svntest.actions.run_and_verify_svn(None, None, errstr,
> + 'cp', dirURL1, dirURL2,
> + '--username', svntest.main.wc_author,
> + '--password', svntest.main.wc_passwd,
> + '-m', 'fooogle')
EXPECTED STDERR:
svn: Path 'G' not present
ACTUAL STDERR:
/home/julianfoad/src/subversion/subversion/libsvn_repos/commit.c:303:
(apr_err=160016)
svn: Path 'G' not present
EXCEPTION: SVNLineUnequal
FAIL: copy_tests.py 25: svn cp src-URL non-existent-URL-path
It appears that you have not been using "maintainer mode" ("configure
--enable-maintainer-mode"). You should do when you are a developer, because it
gives stronger compile-time checking. It also makes Subversion give more
detailed error messages, causing this test to fail. See how other tests avoid
this problem.
Apart from that, your patch is ready to commit.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 16 15:40:02 2005