[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]Issue #1776 (v2) - Create parent directories with 'svn

From: S.Ramaswamy <ramaswamy_at_collab.net>
Date: 2005-03-16 09:17:33 CET

> Thanks for helping with this work. These comments are about the issue
> in general, not specifically about the part that you wrote.
> S.Ramaswamy wrote:
>> Partial patch for Issue #1776 to make parent directories. The code
>> changes to introduce a new cmd line option - '-p|--parents', to make
>> parent
> I'm not sure that the short option name '-p' is deserved, since few of
> the svn commands can use it.

Looks like you prefer the long option "--parents" to be the sole option for
creating parent directories. This could be changed in the next version of
the patch.

>> directories in the working copy, and the related tests in the test
>> suite are from Stephen Oberholtzer. I am including it here to make it
>> easier to review the patch. My changes and test are for directly
>> creating parent directories in the repository.
>> Log :
> The log message(s) will need a summary, will need tidying up, and will
> need completing (e.g. it doesn't mention the changes in svn_client.h).
> I realise that you have just pasted partial messages from the two
> patches in issue #1776 for us to have a quick look, and that you don't
> have much time for this now. Perhaps Stephen Oberholtzer or somebody
> else can pick it up?
> As noted in the issue, the commands to which this is relevant and their
> current behaviours are:
> svn import creates intermediate directories
> svn mkdir does not
> svn copy does not
> svn move does not
> These commands should all be able to create intermediate directories.
> It would be nice to add the option to mkdir, copy and move
> simultaneously. (This patch only covers 'mkdir'.)

Agreed, (a)wc->wc copy (b) wc->wc move (c) url->wc copy are done, since it
only involves re-using a function introduced in the patch for 'svn mkdir

I will try to post a patch with changes to copy and move as well.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 16 09:19:03 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.