[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2214: poor error message when intermediate dir missing in copy

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-03-15 18:27:34 CET

Madan US wrote:
> [[[
> Fixed Issue #2214: poor error message when intermediate dir missing
> in copy.
>
> * subversion/tests/clients/cmdline/copy_tests.py
> (url_2_non_existent_url_path): Added to test
> 'svn cp' into a directory path in which

Unfinished sentence.

>
> * subversion/libsvn_repos/commit.c
> (open_directory): Removed call of
> out_of_date() and added apropriate error
> message.
> ]]]

Please could you try to make your attachments have a text MIME type, rather
than "application/octet-stream", so that we can see them more easily?

> Index: subversion/libsvn_repos/commit.c
> ===================================================================
> --- subversion/libsvn_repos/commit.c (revision 13397)
> +++ subversion/libsvn_repos/commit.c (working copy)
> @@ -300,7 +300,9 @@
> else return an out-of-dateness error. */
> SVN_ERR (svn_fs_check_path (&kind, eb->txn_root, full_path, pool));
> if (kind == svn_node_none)
> - return out_of_date (full_path, eb->txn_name);
> + return svn_error_createf (SVN_ERR_FS_NOT_DIRECTORY, NULL,
> + _("Path '%s' not present"),
> + path);

This code doesn't agree with the comment just above it. (It didn't before, but
that's no excuse.)

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 15 18:28:48 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.