Re: svn_auth_cred_simple_t crash

Greg Hudson wrote:
> On Sun, 2005-03-13 at 09:56, Martin Hauner wrote:
>
>>The description for svn_auth_cred_simple_t in svn_auth.h doesn't state
>>that username or password have to be not 0.
>
> The man page for strcmp() does not say that the two string parameters
> have to not be 0. The man page for fopen() does not say that the
> filename prameter has to not be 0.

Fine, but that doesn't imply it is bad thing to document it just
because strcmp doesn't do it. Maybe it should.

> Silence generally implies that a pointer parameter must be non-NULL.
>
>>And there is no problem with passing 0 as username.
>
> "It happens to work" is not an API promise.

I would prefer a crash for both or no for both, at least it would
be consistent. ;)

-- 
Martin
Subcommander, http://subcommander.tigris.org
a x-platform Win32/Unix svn gui (qt) client & a text diff/merge tool.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org