[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_auth_cred_simple_t crash

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2005-03-13 18:50:51 CET

On Mar 13, 2005, at 8:56 AM, Martin Hauner wrote:
> If you think it should be not 0, i can create a doc patch for it.

Hm, yes, would you do that? :-)

>> I would argue that the bug is in your client. If the user doesn't
>> enter a password, then it should return a credentials structure with
>> password = "".
> Sure, that's the way i avoid the crash. But it would be less code on my
> side if the svn lib would do the check :)

We had a discussion about these sorts of APIs earlier this week on the
list; in general, we decided that NULL input parameters are not
allowed unless the docstring explicitly says so. In that same spirit,
I think that fields of any sort of auth credential structure shouldn't
come back as NULL unless the docstring explicitly says so.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Mar 13 18:52:12 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.