[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svnserve pools and svn_fs_access_t

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2005-03-12 00:37:54 CET

On Fri, 2005-03-11 at 17:55, Ben Collins-Sussman wrote:
> I'm not sure how to fix this. Any suggestions from those who know
> svnserve better? Lundblad, ghudson, etc.?

A similar issue exists for the "user" field of the server baton
structure. (I thought someone had fixed this, but apparently not, or
perhaps only on the locking branch.)

The server baton should have a pool field. When authentication happens,
the username should be allocated either in that pool or in a subpool,
and the FS access object should be allocated similarly.

(Since in practice, authentication doesn't happen more than one or two
times per connection, using a subpool might be overkill. But
technically it's a memory leak not to do so.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 12 00:39:47 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.