[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2219 Canonicalize values in svn:keywords v4

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-03-11 17:03:22 CET

Madan U Sreenivasan wrote:
> Fixed Issue #2219: Canonicalize values in svn:keywords.
> * subversion/include/svn_types.h
> (SVN_KEYWORD_MAX_LEN): Added comment pointing to
> places where the SVN_KEYWORD_... defines are used.

A comment saying where the names are used is not appropriate, as it is not
maintainable. A comment reminding anyone who changes the definitions to find
and update the uses of them would be more appropriate, but still unnecessary in
my opinion, since it is fairly obvious. Therefore I will just omit this part
of the patch.

The rest all looks good. (I tweaked the whitespace a bit more.)

Committed in r13369.

Thank you very much.

Now we just need someone to update the documentation before we can close issue

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 11 17:04:41 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.