Re: [PATCH] Issue #2219 Canonicalize values in svn:keywords v4

Madan U Sreenivasan wrote:
> Fixed Issue #2219: Canonicalize values in svn:keywords.
>
> * subversion/include/svn_types.h
> (SVN_KEYWORD_MAX_LEN): Added comment pointing to
> places where the SVN_KEYWORD_... defines are used.

A comment saying where the names are used is not appropriate, as it is not
maintainable. A comment reminding anyone who changes the definitions to find
and update the uses of them would be more appropriate, but still unnecessary in
my opinion, since it is fairly obvious. Therefore I will just omit this part
of the patch.

The rest all looks good. (I tweaked the whitespace a bit more.)

Committed in r13369.

Thank you very much.

Now we just need someone to update the documentation before we can close issue
#2219.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 11 17:04:41 2005