Re: [PATCH] Issue #2219 - Canonicalize values in svn:keywords - v3

Madan U Sreenivasan wrote:
> * subversion/libsvn_wc/props.c
> (svn_canonicalize_keywords): New function to

Internal/private functions don't have "svn_" prefix in their name. Maybe I'm
just misreading the tests, but I don't see a place where you attempt to set two
different aliases in svn:keyword and show that only a single canonical entry
results.

Other than that, this looks great to me (I'm running the test suite now)!

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org