[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2219 - Canonicalize values in svn:keywords

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2005-03-09 05:55:29 CET

On Wed, 2005-03-09 at 08:17, Julian Foad wrote:
> John Peacock wrote:
> > Madan U Sreenivasan wrote:
> >> About typedefs in the .h, that is technically the way to go... I just
> >> wasnt sure about adding a structure that is specific only to subst.c
> >> into svn_subst.h. What do you think, John?
> >
> > I can go either way, since this is technically a private structure, used
> > only by that one variable (which I think should probably be initialized
> > within the function, rather than at the file level).
> You imply that the structure is, in some non-technical way, public. I don't
> follow that.
> [...] the variable (canon_table_for_keywords) should be given local linkage by
> adding the "static" keyword or by defining it inside the function that uses it.
I want to define the variable(canon_table_for_keywords) inside the
function and still make it static.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 9 05:49:17 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.