[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2219 - Canonicalize values in svn:keywords

From: John Peacock <jpeacock_at_rowman.com>
Date: 2005-03-09 04:09:35 CET

Julian Foad wrote:
> You imply that the structure is, in some non-technical way, public. I
> don't follow that.

You're right, I wasn't reading it closely enough (at 6:30am local time) to
notice that it was only being used inside the function and hence was confusing
myself (and possibly Mandan).

> local linkage by adding the "static" keyword or by defining it inside
> the function that uses it.

I still think it is better to have the variable be defined within the function
that is using it (since it is not used by any other code). And, of course, I'd
still rather have all of this be a private function inside props.c, since it is
exclusively dealing with data validation of certain properties. There is no
general purpose use for this code elsewhere, even though the rest of the
"keywords" code is stuck in subst.c (except for svn_wc__get_keywords).


John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 9 04:08:23 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.