Re: svn_client_propget target param problem?

Philip Martin <philip@codematters.co.uk> writes:

> Barry Scott <barry@barrys-emacs.org> writes:
>
>> Call svn_client_propget with a single filename as the target and
>> recurse False.
>>
>> The returned props has a single entry in it. But the key did not come
>> from the
>> pool its the address of the passed in target param.
>>
>> This causes a problem if the memory used for the target is reused
>> before
>> the props are processed.
>>
>> Am I right in thinking that this is bug in the implementation of
>> svn_client_propget?
>
> Yes.
>
>> Shouldn't the key be allocated out of the pool I pass in?
>
> It should, see the documentation in svn_client.h.

There is another bug as well: the documentation states that the
key/value pair should only be stored if the property is set but the
code appears to store them unconditionally.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org