[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_client_propget target param problem?

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-03-06 22:06:33 CET

Philip Martin <philip@codematters.co.uk> writes:

> Barry Scott <barry@barrys-emacs.org> writes:
>> Call svn_client_propget with a single filename as the target and
>> recurse False.
>> The returned props has a single entry in it. But the key did not come
>> from the
>> pool its the address of the passed in target param.
>> This causes a problem if the memory used for the target is reused
>> before
>> the props are processed.
>> Am I right in thinking that this is bug in the implementation of
>> svn_client_propget?
> Yes.
>> Shouldn't the key be allocated out of the pool I pass in?
> It should, see the documentation in svn_client.h.

There is another bug as well: the documentation states that the
key/value pair should only be stored if the property is set but the
code appears to store them unconditionally.

Philip Martin
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Mar 6 22:07:43 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.