weirdness in svn:// uri parsing

hi

littlejohn on #svn just found a little bug in the uri parser for svn://
[[[
svn ls svn://localhost:/
svn: Can't connect to host 'localhost': Connection refused
]]]

should it complain about unspecified port here?

for http:
[[[
svn ls http://localhost:/
svn: PROPFIND request failed on '/'
svn: PROPFIND of '/': 405 Method Not Allowed (http://localhost)
]]]

strace -e trace=connect svn ls http://localhost:/
[[[
connect(3, {sa_family=AF_INET6, sin6_port=htons(0), inet_pton(AF_INET6, "::1", &sin6_addr), sin6_flowinfo=0, sin6_scope_id=0}, 28) = 0
connect(3, {sa_family=AF_INET, sin_port=htons(0), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
connect(3, {sa_family=AF_INET, sin_port=htons(80), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
]]]

strace -e trace=connect svn ls http://localhost:/
[[[
connect(3, {sa_family=AF_INET, sin_port=htons(0), sin_addr=inet_addr("127.0.0.1")}, 16) = -1 ECONNREFUSED (Connection refused)
]]]

funny too:
[[[
svn ls file://localhost:/
svn: Unable to open an ra_local session to URL
svn: Local URL 'file://localhost:' contains only a hostname, no path
]]]

hope this helps

darix

-- 
irssi - the client of the smart and beautiful people
              http://www.irssi.de/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org