Re: Code review requested.

"Brian W. Fitzpatrick" <fitz@collab.net> writes:

> On Wed, 2005-03-02 at 19:01 +0000, Philip Martin wrote:
>> Philip Martin <philip@codematters.co.uk> writes:
>>
>> > Looks like at least one of your subpool changes is wrong:
>> >
>> > $ subversion/tests/libsvn_fs_base/fs-test 23
>> > Segmentation fault
>>
>> I've just confirmed that reverting r13208 makes this crash go away.
>
> I'm unable to reproduce as of r13225 on trunk:
>
> $ ./subversion/tests/libsvn_fs_base/fs-test 23
> PASS: lt-fs-test 23: merging commit

The bug involves using pool memory after the pool has been cleared, do
you have APR's pool debugging enabled? It's normal for these bugs not
to show up unless you have pool debugging enabled, mainly because our
test cases are small, single threaded and don't use much memory. That
doesn't make the problem less serious, using pool memory after the
pool has been freed is always a bug.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org