Brian W. Fitzpatrick wrote:
>
> On Feb 26, 2005, at 10:28 AM, Ben Collins-Sussman wrote:
>
>>
>> On Feb 26, 2005, at 6:43 AM, Daniel Kastenholz wrote:
>>
>>>
>>> Any architecture- or style-related suggestions, remarks, hints... ?
>>>
>>
>> I would very much like to see svnserve grow the equivalent of
>> apache's "accesslog" and "errorlog". Many users have been asking
>> for this. I don't imagine it would be tremendously difficult to do,
>> but nobody's had time to do it yet.
>>
>> By the way, the svnserve protocol is documented here in the
>> libsvn_ra_svn/ dir:
>>
>> http://svn.collab.net/repos/svn/trunk/subversion/libsvn_ra_svn/
>> protocol
>>
>> ...so I'd use that -- as well as svn_ra.h -- as your guidelines to
>> understanding what's going on in terms of client/server requests.
>> I'd not only like to see a traffic counter being logged for each
>> connection, but also each 'command' sent by the client being logged
>> in an accesslog. And svnserve errors written to errorlog.
>>
>> If you have time to work on this, that's great. Be sure to read
>> HACKING to understand how to submit patches for review. And be sure
>> to work against svn's latest /trunk code, not some released tarball.
>
>
> Would we really want to put the logging layer into svnserve? I don't
> have a solution in mind ATM, but it *would* be nice to see some
> generic mechanism that could be configured to log the various
> commands run against a repository... maybe something like an access
> hook or something?
We talked about this a while ago. Yes, we should have both logging and
debug tracing in our code eventually (and note that these are two
entirely different things).
Daniel, whatever you do, *please* don't try to invent yet another
logging library. Use one of the millions that exist already; it must be
protable (at least Unix and Windows), and it must be able to connect to
syslog on Unix (but not _only_ to syslog).
A good first step might be to take the logging code from Apache and
making a separate library out if it (perhaps within APR?).
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 2 09:33:42 2005