Re: svn commit: r13115 - trunk/build/ac-macros

maxb@tigris.org writes:

> Author: maxb
> Date: Tue Feb 22 14:17:26 2005
> New Revision: 13115
>
> Modified:
> trunk/build/ac-macros/svn-macros.m4
> Log:
> * build/ac-macros/svn-macros.m4 (SVN_CONFIG_NICE): Prefix the reinvocation of
> configure with "exec" - this makes the config.nice file itself be closed,
> before configure attempts to rewrite it - this matters on Cygwin.
>
> Also, suppress adding --no-recursion or --no-create to ./config.nice, since
> config.status --recheck appends these options, which are likely not to be
> wanted when config.nice is used.
>
>
> Modified: trunk/build/ac-macros/svn-macros.m4
> Url: http://svn.collab.net/viewcvs/svn/trunk/build/ac-macros/svn-macros.m4?view=diff&rev=13115&p1=trunk/build/ac-macros/svn-macros.m4&r1=13114&p2=trunk/build/ac-macros/svn-macros.m4&r2=13115
> ==============================================================================
> --- trunk/build/ac-macros/svn-macros.m4 (original)
> +++ trunk/build/ac-macros/svn-macros.m4 Tue Feb 22 14:17:26 2005
> @@ -17,8 +17,15 @@
>
> EOF
>
> - for arg in [$]0 "[$]@"; do
> - echo "\"[$]arg\" \\" >> $1
> + echo "exec \"[$]0\" \\" >> $1
> + for arg in "[$]@"; do
> + case $arg in
> + --no-create) ;;
> + --no-recursion) ;;
> + *)
> + echo "\"$arg\" \\" >> $1
> + ;;
> + esac
> done
> echo '"[$]@"' >> $1
> chmod +x $1

I don't like this change. In the past when I ran:

   $ ../svn/configure ...

the generated config.nice script contained:

   "../svn/configure"

Now the generated config.nice contains

   exec "../svn/configure"

and when run it gets regenerated containing an absolute path

   exec "/home/pm/sw/subversion/obj/../svn/configure"

The absolute path is a problem, I don't want to invoke configure with
an absolute path as it has knock on effects, in particular it appears
in the debug information.

If Cygwin needs the exec then please make it Cygwin specific and don't
impose it on the rest of us.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org