[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]Issue #2219 - svn:keywords canonicalization

From: John Peacock <jpeacock_at_rowman.com>
Date: 2005-03-01 13:51:10 CET

Madan U Sreenivasan wrote:
> Fixed Issue #2219: Canonicalizing the svn:keywords


This doesn't canonicalize the keywords, this just removes the case sensitivity.
  This is the worst of both worlds, since it now permits AuThOr to be set as a
keyword and then people will ask, "But I set it that way in the file, too, and
it doesn't expand!"

Please see my recommended changes here:


which documents where to intercept /setting/ the svn:keywords to a standard
form. The case-sensitivity should not be removed, but rather the code should
silently correct the case to match what is going to be accepted inside the file.
  Note that we are only talking about svn:keywords here; all keywords inside
files are still case-sensitive.

On the bright side, the patch is very well written, with a good commit message
and even tests (but no documentation fix, which should be part of this change).
  So don't get discouraged!


John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 1 13:51:22 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.