Re: [PATCH]Issue #2219 - svn:keywords canonicalization

Madan U Sreenivasan wrote:
> Fixed Issue #2219: Canonicalizing the svn:keywords

-1

This doesn't canonicalize the keywords, this just removes the case sensitivity.
  This is the worst of both worlds, since it now permits AuThOr to be set as a
keyword and then people will ask, "But I set it that way in the file, too, and
it doesn't expand!"

Please see my recommended changes here:

        http://svn.haxx.se/dev/archive-2005-02/0217.shtml

which documents where to intercept /setting/ the svn:keywords to a standard
form. The case-sensitivity should not be removed, but rather the code should
silently correct the case to match what is going to be accepted inside the file.
  Note that we are only talking about svn:keywords here; all keywords inside
files are still case-sensitive.

On the bright side, the patch is very well written, with a good commit message
and even tests (but no documentation fix, which should be part of this change).
  So don't get discouraged!

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org