Re: abort_edit in perl and python

Chia-liang Kao wrote:
> Three batons with a refcnt of 1, since they need to be held for
> apply_textdelta or child directories.

OK, that makes more sense. Do these batons have a DESTROY method? I can't look
at the code at the moment (got to go shovel the walk and then keep the kids busy
until school starts two hours late for a couple inches of snow). <ARGHHH>

>
> No, there's currently no such list maintained in the editor baton.

That's a pity, but not unsurmountable.

>
>
>>If there is a DESTROY for each object involved, this should also unwind the
>>editor baton refcnt.
>>
>
>
> huh? it's because the svn/perl bit holds the refcnt so the editor object is
> not freed and thus DESTROY is not called.

I was saying that the DESTROY on the *delta_editor* batons should decrement the
refcnt on the *editor* object. If the delta_editor batons don't actually
contain a reference to the editor object, then indeed the editor object should
not be incremented in the first place.

> It's not like blowing away their memory address. There's a util function
> in libsvn_swig_perl to make a pool decrease refcnt of an SV upon pool
> cleanup.

That makes me much happier, but it is still going outside of the Perl garbage
cleanup. I think it is preferable to have the batons clean up themselves if at
all possible.

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org