[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

abort_edit in perl and python

From: Chia-liang Kao <clkao_at_clkao.org>
Date: 2005-03-01 09:59:27 CET


a delta_editor implementation in perl or python increase refcnt for the baton
returned by {add,open}_{file,directory}, and decreased in close. If the driver
calls abort_edit at some point, those batons are leaked. Actually even worse,
the editor baton (which is the instance of the editor object) is leaked, because
its refcnt is increased too for every add/open, I'm not sure if this is
neccessary. And from the svn_delta.h we can't call close_* after abort_edit for
clearing those refcnts:

  Moreover, once an editing
  function returns an error, the edit is dead; the only further
  operation which may be called on the editor is abort_edit.

So my plan for rescuing the batons are to make the baton refcnt held by the
respective file/dir pool. Or do we have a better way to make abort_edit more
graceful in this case?


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 1 10:07:01 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.