[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add more gettext support for subversion/libsvn_repos/load.c

From: Kobayashi Noritada <nori1_at_dolphin.c.u-tokyo.ac.jp>
Date: 2005-02-25 13:03:39 CET

Hi,

Thank you for your approval. Committed at r13150.

> > This patch adds more gettext support for subversion/libsvn_repos/load.c.
>
> +1, please commit. BTW: Is there any reason not to combine the other patch
> with this one? (I know, you already committed it... Just curious.)

r13150 is merely marking strings with _() without modifying those strings
and enabling translation, although r13149 is accompanying little change in
the code and dividing a string into two.
So, I thought they are "unrelated" and followed the description in the
HACKING:

  A patch submission should contain one logical change; please don't mix
  N unrelated changes in one submission -- send N separate emails
  instead.

Actually I found both at once in checking Issue 1997 fixed. :-)

Regards,

-- 
|:  Noritada KOBAYASHI
|:  Dept. of General Systems Studies,
|:  Graduate School of Arts and Sciences, Univ. of Tokyo
|:  E-mail: nori1@dolphin.c.u-tokyo.ac.jp (preferable)
|:          nori@esa.c.u-tokyo.ac.jp
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 25 13:04:47 2005

This is an archived mail posted to the Subversion Dev mailing list.