[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r13016 - trunk/subversion/libsvn_fs_fs

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2005-02-15 16:47:52 CET

On Tue, 2005-02-15 at 02:13, Branko ╚ibej wrote:
> I hav eone objection to this change:
>
> > /* Combine in the windows from the other delta reps, if needed. */
> >- for (i = 1; i < rb->rs_list->nelts; i++)
> >+ for (i = 1; i < rb->rs_list->nelts - 1; i++)
> >
> >
> This relies far too much on the assumption that the first revision is
> the only on that can be self-compressed.

rb->rs_list is an array of the deltas used to represent the file,
constructed by build_rep_list(), not an array of the revisions of the
file. So no such assumption is being made.

(If we see "delta -> delta -> delta -> plaintext", something FSFS
currently never does, it's true that Peter's code will apply the final
delta to the plaintext even though that delta is not self-compressed.
That's arguably wrong from a performance perspective, though it's still
correct behavior.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 15 17:01:02 2005

This is an archived mail posted to the Subversion Dev mailing list.