[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r13016 - trunk/subversion/libsvn_fs_fs

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2005-02-15 08:13:35 CET

lundblad@tigris.org wrote:

>Author: lundblad
>Date: Mon Feb 14 14:29:00 2005
>New Revision: 13016
>
>Modified:
> trunk/subversion/libsvn_fs_fs/fs_fs.c
>Log:
>In FSFS, when recreating a fulltext, instead of combining al deltas, apply
>one delta against a fulltext or the empty stream and combine the rest.
>
>
I hav eone objection to this change:

> /* Combine in the windows from the other delta reps, if needed. */
>- for (i = 1; i < rb->rs_list->nelts; i++)
>+ for (i = 1; i < rb->rs_list->nelts - 1; i++)
>
>
This relies far too much on the assumption that the first revision is
the only on that can be self-compressed. Insted, the logic should simply
be to stop combination when we find a fulltext /or/ self-compressed
delta. some future optimisation could insert self-compressed deltas
anywhere, and it's also not impossible to mix self-compressed and diffed
deltas in different windows of the same revision.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 15 08:14:47 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.