On Feb 14, 2005, at 11:01 AM, John Peacock wrote:
> Ben Collins-Sussman wrote:
>
>> C. When reading locks from the repository:
>> 1. svnserve (and other non-dav readers) continue to read locks
>> normally, ignoring the new boolean field. If extra XML junk
>> ends up being marshalled back to the client, that simply
>> means the lock was created by a generic DAV client. No big
>> deal.
>
> Is there some reason why the boolean == 1 cannot mean that svnserve
> strips the XML wrapper before marshalling the data back to the client?
> Or is this just about fixing mod_dav_svn to DTRT to minimize the
> amount of code that has to care about <D:author>?
>
svnserve certainly *could*, but I'm not sure it would be worth it.
For example, if MSWord creates a lock with a comment that looks like
<D:author foo="bar" aoeuth="crpylwh">
<tag1>
<tag2>
... 37 other complicated tags full of attributes and weird cdata
...
</tag2>
<tag1>
</D:author>
Then the most svnserve could do is strip the <D:author> stuff when
sending the lock back to the client. It's not really going to make the
comment much more readable. :-)
So yeah, I guess we're just trying to minimize code here. Normal RA
layers ignore the new boolean field. mod_dav_svn pays careful
attention to it, as a means of staying interoperable with the rest of
svn.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 14 18:13:59 2005