Re: svn commit: r12968 - in branches/locking/subversion: include libsvn_subr libsvn_wc

"Brian W. Fitzpatrick" <fitz@collab.net> writes:

> I think that doing this check each time without the cache could be a
> real slowdown, so for now (based on some conversation with ghudson),
> I'm inclined to pull all of this default perms code and just chmod o+w
> the file outright.

I don't like the fact that we already do o+x, I like o+w even less.

> Or do you think it's worth the effort to do the
> open/stat/close once for each file?

I'd be happy caching the default permissions in the access batons. It
would mean that a process that changes umask while using an access
baton cannot guarantee that the umask will be respected, but that's an
acceptable limitation as far as I am concerned.

It might even be possible to populate such a cache on the fly when
libsvn_wc creates one of it's many temporary files. Obviously that
would mean having a fallback that creates a dummy file if the cache is
empty.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org