[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Locking: RFC: svn:needs-lock behaviors Part Deux

From: Brian W. Fitzpatrick <fitz_at_collab.net>
Date: 2005-02-03 23:27:26 CET

On Feb 3, 2005, at 2:30 PM, Peter N. Lundblad wrote:

> On Thu, 3 Feb 2005, Brian W. Fitzpatrick wrote:
>> svn:needs-lock behaviors:
>> =========================
>> Update:
>> Propset:
>> - Setting the svn:needs-lock property does the following:
>> - If the file is not locked, it sets the file to read-only.
>> - If the file is locked, it does nothing.
>> - If file has local mods, it does nothing (see Commit, below)
>> - If the file is scheduled to be added, it does nothing (see
>> Commit,
>> below)
> I like ghudson's suggestion to make the read-only state depend on the
> propsbase value of svn:needs-lock. This would mean that propset won't
> touch the read-only state. My reasoning is that we don't need to
> protect
> the users from themselves in this case, we want to protect users from
> stepping on other users feet. So, svn:needs-lock only really takes
> effect
> on commit.

Ah, OK. So any propset of svn:needs-lock will flip perms at commit
time, right?

> BTW, have we specified if properties are made read-only if
> svn:needs-lock
> is set, disallowing pset and pedit if needs-lock is set and the file is
> not locked?

Interesting idea, but it doesn't have a workaround like the file perms
do (any knowledgeable user can flip the write bit on a file manually).
Still, I like that idea. What do the rest of you think?

>> Commit:
>> - If a file has the svn:needs-lock property set:
>> - If file had local mods, set the file to read-only.
> ONly if file is unlocked, ofcourse.




To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 3 23:28:46 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.