[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: Fix some pool usage (non-use of sub-pools)

From: <kfogel_at_collab.net>
Date: 2005-01-31 21:08:30 CET

Julian Foad <julianfoad@btopenworld.com> writes:
> Log message:
> [[[
> Fix some pool usage.
> * subversion/libsvn_client/add.c
> (svn_client_mkdir): Actually use the sub-pool that we created. Clear it at
> at the beginning rather than the end of the loop, as per our policy.
> * subversion/mod_dav_svn/repos.c
> (dav_svn_do_walk): Remove the unused sub-pool, as no pool is needed.
> ]]]

+1 on both, nice catches!

These cleanups are great. You're becoming, like, the drill sergeant
of the svn code. "If a quarter doesn't bounce off this subroutine,
it's not tight enough!" :-)


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 31 21:20:17 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.