[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #1310: Clear iteration pools at start of loop

From: <kfogel_at_collab.net>
Date: 2005-01-31 21:05:42 CET

Julian Foad <julianfoad@btopenworld.com> writes:
> + subversion/libsvn_client/commit.c (svn_client_import):
> The patch adds a 'destroy' at the end of the function. Does that
> invalidate 'commit_info' which seems to be allocated in the subpool
> and then returned to the caller? An import seems to work OK, and
> passes 'make check', even if I 'clear' just before 'destroy', but is
> it right? I think I will remove it from the patch if I don't find out
> for sure that it's safe.

Agreed. Maybe we should just be passing 'pool' instead of 'subpool'
to get_ra_editor(). In the current code, the effect would be the
same, and if we were to change svn_client_import() to destroy the
subpool at the end, I don't see how it could possibly be correct
w.r.t. the allocation of commit_items (at least, tracing the code
through indicates that commit_items are allocated in the explicit
pool, not the session pool or some other sneaky way).


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 31 21:17:38 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.