[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Use a short date format in "blame -v"

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-01-28 02:02:33 CET

Bruce DeVisser wrote:
> Julian Foad wrote:
>>What say you about "svn list -v" then? Same arguments
>>apply. I suppose I'd better submit an alternative patch
>>which "fixes" the date in "svn list -v" to make it
>>unambiguous but verbose, and see what the reaction to that
> I wouldn't object, but I suspect a number would not like the
> ping-ponging of format.

Well, I would object to making "ls -v" use the long date format that "blame -v"
and "log" currently use, but some intermediate form is a possibility, but I
agree that the "ping-ponging" of format would be objectionable in itself.

> But if I recall correctly, the purpose of the change to the
> current ls -v format was to mimic unixish ls -l behaviour.
> There is no such analogy for blame output.

I assumed that that date format was just chosen as one that happens to be
appropriately short and human-readable.

I am not aware of any particular desire to mimic "ls -l", though we do mimic it
to some extent. The date format printed by GNU "ls -l" depends on locale. My
locale is "en_GB.UTF-8" and it prints a form that I rather like:

~/src/subversion> /bin/ls -l apr
total 1758
-rw-r--r-- 1 julianfoad users 82521 2005-01-27 23:53 CHANGES
-rw-r--r-- 1 julianfoad users 16011 2005-01-27 23:53 LICENSE

In fact, testing what "svn list -v" does in other locales, I get:

~/src/subversion> LC_TIME="de_DE" svn ls -v apr
  125349 mturk 82521 Jan 16 07:30 CHANGES
  109914 rooneg 16011 Dez 05 21:34 LICENSE

which again doesn't match GNU "ls" in that locale, and:

~/src/subversion> LC_TIME="fr_FR" svn ls -v apr
  125349 mturk 82521 jan 16 07:30 CHANGES
/home/julianfoad/src/subversion/subversion/libsvn_subr/utf.c:454: (apr_err=22)
svn: Valid UTF-8 data
(hex: 64)
followed by invalid UTF-8 sequence
(hex: e9 63 20 30)

Is that just because my system isn't configured properly for French, or a bug?
  It's trying to print 'd', e-acute, 'c', but the e-acute is not in UTF-8.

> And isn't the current blame format already consistent with the canonical
> input format?

You mean the format used for dates in "svn --revision {DATE}" ? (That's the
only date input that I know of.) The long date output starts off with a chunk
that is compatible, and then adds another chunk that isn't. Certainly the
current output of "svn list -v" is not compatible

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 28 02:03:40 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.